hack/scripts-dev: add "docker-dns-example-certs-common-name-run" #8961
Conversation
| --endpoints=https://m1.etcd.local:2379,https://m2.etcd.local:22379,https://m3.etcd.local:32379 \ | ||
| get abc | ||
|
|
||
| sleep 1s && printf "\n" |
There was a problem hiding this comment.
no sleep?
same as many places down below/
There was a problem hiding this comment.
Let's keep sleep here. I am trying to put example workflow here with print statements. Otherwise, it's hard to follow.
| get abc | ||
|
|
||
| sleep 1s && printf "\n" | ||
| echo "Step 1. creating root role" |
There was a problem hiding this comment.
I don't quite understand this test.
why are we creating root user and root role?
There was a problem hiding this comment.
User must create root user and role first. It's special user and role. https://github.com/coreos/etcd/blob/master/Documentation/op-guide/authentication.md#special-users-and-roles
There was a problem hiding this comment.
you are testing this scenario right?https://github.com/coreos/etcd/blob/master/Documentation/op-guide/authentication.md#using-tls-common-name
gyuho
force-pushed
the
test-scripts-4
branch
6 times, most recently
from
cf95d67
to
5071711
Compare
Codecov Report
@@ Coverage Diff @@
## master #8961 +/- ##
=========================================
Coverage ? 76.06%
=========================================
Files ? 359
Lines ? 29837
Branches ? 0
=========================================
Hits ? 22695
Misses ? 5570
Partials ? 1572Continue to review full report at Codecov.
|
gyuho
force-pushed
the
test-scripts-4
branch
from
5071711
to
c0afdbe
Compare
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
| mv ca.pem ca.crt | ||
| openssl x509 -in ca.crt -noout -text | ||
|
|
||
| # generate wildcard certificates DNS: *.etcd.local |
There was a problem hiding this comment.
it doesn't seems like you are generating wildcard certificates from server-ca-csr.json
"hosts": [
"m1.etcd.local",
"m2.etcd.local",
"m3.etcd.local",
"127.0.0.1",
"localhost"
]
|
this script is more a demo of how to use common name than a test script. suggest rename this as a demo script. |
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
gyuho
force-pushed
the
test-scripts-4
branch
from
c0afdbe
to
5783460
Compare
gyuho
changed the title
Address #8502.
Separate out from #8954.
/cc @fanminshi